Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded a lot of libraries #286

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Upgraded a lot of libraries #286

merged 4 commits into from
Dec 12, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 12, 2024

This PR upgrades all the dependencies, and also go-git, it should solve the issue in #287

@cmaglie
Upgraded a lot of libraries
bdf4d2d
@cmaglie
Fixed unit test
13b2e21 
It wasn't passing because the reference name had spaces in the string
(creating invalid references). The updated git library has enforced
stricter checks on the ref name.
@cmaglie
small refactoring, no code changes
1eb6093
@cmaglie
Fixed another unit test
02bcba1 
Branch creation now forces the use of at least one slash "/" for better
branch self-description. This sound quite arbitrary from the go-git
library, but that's how it is.
alessio-perugini
alessio-perugini approved these changes Dec 12, 2024
View reviewed changes
Copy link

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test changes/refactor looks good.

@cmaglie cmaglie merged commit b038cc3 into main Dec 12, 2024
53 checks passed
@cmaglie cmaglie deleted the upgrade_libs branch December 12, 2024 16:59
@per1234
Copy link
Contributor

per1234 commented Dec 17, 2024

it should solve the issue in #287

It did not:

https://downloads.arduino.cc/libraries/logs/github.com/gooddisplayshare/ESP32epd/

2024/12/17 11:07:08 Scraping https://github.com/gooddisplayshare/ESP32epd.git
2024/12/17 11:07:08 Checking out tag: v1.0.1
2024/12/17 11:07:09 Release ESP32epd:1.0.3 already loaded, skipping
2024/12/17 11:07:09 Checking out tag: v1.0.2
2024/12/17 11:07:10 Release ESP32epd:1.0.3 already loaded, skipping
2024/12/17 11:07:10 Checking out tag: v1.0.3
2024/12/17 11:07:10 Release ESP32epd:1.0.3 already loaded, skipping

This shows that libraries-repository-engine is seeing a value of 1.0.3 for the version property of library.properties after checking out each tag, but that is not correct:

https://github.com/gooddisplayshare/ESP32epd/blob/v1.0.1/library.properties#L2

version=1.0.1

https://github.com/gooddisplayshare/ESP32epd/blob/v1.0.2/library.properties#L2

version=1.0.2

https://github.com/gooddisplayshare/ESP32epd/blob/v1.0.3/library.properties#L2

version=1.0.3

I moved #287 back to the "Backlog" column in the "Tooling Team" project.

@per1234
Copy link
Contributor

per1234 commented Dec 17, 2024

Ah, nevermind. I thought this made it into the release, but then I noticed the little "This PR’s merge commit doesn’t appear in any tags" Refined GitHub added to the bottom of the PR thread after I commented, and I see that it is not in the release.

@cmaglie
Copy link
Member Author

cmaglie commented Dec 17, 2024

It should be all resolved now 👍🏼

This was referenced Dec 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

@Xayton Xayton Awaiting requested review from Xayton

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaglie @per1234 @alessio-perugini