Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update name and URL of "esp-brookesia" #5156

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Update name and URL of "esp-brookesia" #5156

merged 2 commits into from
Oct 2, 2024

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Sep 24, 2024

This PR consists of two changes:

  • Change URL from https://github.com/espressif/esp-ui.git to https://github.com/espressif/esp-brookesia.git (companion to Remove some libraries #5155)
  • Change name from esp-ui to esp-brookesia

Since the name change operation on the database is actually a removal followed by automated re-indexing on the next job run, the URL update will occur as a matter of course. For this reason, the only operation required from the backend maintainer is a standard name change procedure.

@per1234 per1234 added topic: URL change Change library repository URL topic: rename Change registered library name status: pending backend Depends on backend maintenance operations labels Sep 24, 2024
@MatteoPologruto MatteoPologruto self-assigned this Oct 2, 2024
MatteoPologruto
MatteoPologruto approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/10/02 16:10:50 Loaded 7334 libraries from DB
Removing esp-ui
Success!

@MatteoPologruto MatteoPologruto merged commit 1241702 into arduino:production Oct 2, 2024
2 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Oct 2, 2024
@per1234 per1234 deleted the update-esp-brookesia branch October 11, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

Assignees

@MatteoPologruto MatteoPologruto

Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: rename Change registered library name topic: URL change Change library repository URL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@per1234 @MatteoPologruto