-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support only the new protobuf versioning scheme #78
Conversation
cb3c120
to
a7fbd04
Compare
a7fbd04
to
7295d7c
Compare
4489278
to
825fbe0
Compare
eece000
to
c83d22f
Compare
f988aa3
to
aaa9e8c
Compare
aaa9e8c
to
6b3124e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Were tags deleted as a part of this effort? Our team had a dependency on |
@jbohanon do you mind pasting how you pinned the action? Something Like:
We didn't touch any older tags 🤔 |
Thanks for the prompt response! We had seen:
We are now testing the following with success. Looks like there was smoke but no fire. 😄 Thanks again
|
@jbohanon Yup that's because the 28fd3e5 will be released ~tomorrow as a v2 breaking change. Honestly, I didn't think about the users referencing the action with EDIT: opened #81 for future users that may be facing the same issue |
It's all good, I see now that your documentation has called out for quite some time that users should reference |
Support for new protobuf tag naming
vMINOR.PATCH
.This require a bump to
v2
After v3.20.0 the pre-compiled binaries are pushed only for minor.patch tags.
Looking at the docs I think the best way to handle this is to bump a new major of our GA and start supporting only the minor.patch tags. This would make our life easier (at least until protobuf team doesn't want to change the tag strategy again 🤣 )