Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only the new protobuf versioning scheme #78

Merged
merged 1 commit into from
May 30, 2023

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented May 26, 2023

Support for new protobuf tag naming vMINOR.PATCH.
This require a bump to v2

After v3.20.0 the pre-compiled binaries are pushed only for minor.patch tags.
Looking at the docs I think the best way to handle this is to bump a new major of our GA and start supporting only the minor.patch tags. This would make our life easier (at least until protobuf team doesn't want to change the tag strategy again 🤣 )

@alessio-perugini alessio-perugini force-pushed the upgrade-to-v2 branch 4 times, most recently from cb3c120 to a7fbd04 Compare May 26, 2023 17:21
@alessio-perugini alessio-perugini self-assigned this May 26, 2023
@alessio-perugini alessio-perugini linked an issue May 26, 2023 that may be closed by this pull request
3 tasks
@alessio-perugini alessio-perugini force-pushed the upgrade-to-v2 branch 4 times, most recently from 4489278 to 825fbe0 Compare May 29, 2023 11:56
@alessio-perugini alessio-perugini changed the base branch from master to update-deps May 29, 2023 11:56
@alessio-perugini alessio-perugini force-pushed the upgrade-to-v2 branch 2 times, most recently from eece000 to c83d22f Compare May 29, 2023 12:10
Base automatically changed from update-deps to master May 29, 2023 12:27
@alessio-perugini alessio-perugini force-pushed the upgrade-to-v2 branch 6 times, most recently from f988aa3 to aaa9e8c Compare May 29, 2023 12:58
@alessio-perugini alessio-perugini marked this pull request as ready for review May 29, 2023 13:34
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 30, 2023
@alessio-perugini alessio-perugini merged commit 28fd3e5 into master May 30, 2023
@alessio-perugini alessio-perugini deleted the upgrade-to-v2 branch May 30, 2023 08:48
@jbohanon
Copy link

jbohanon commented May 30, 2023

Were tags deleted as a part of this effort? Our team had a dependency on 3.6.1, and we are now broken. Is there documentation on if/how the old tags are mapped to existing tags?

@alessio-perugini
Copy link
Contributor Author

@jbohanon do you mind pasting how you pinned the action? Something Like:

        uses: arduino/setup-protoc@v1
        with:
          version: v3.16.0

We didn't touch any older tags 🤔

@jbohanon
Copy link

jbohanon commented May 30, 2023

Thanks for the prompt response! We had seen:

Run arduino/setup-protoc@master
  with:
    version: 3.6.1
    repo-token: ***
    include-pre-releases: false
Error: Error: unable to get latest version

We are now testing the following with success. Looks like there was smoke but no fire. 😄 Thanks again

        uses: arduino/setup-protoc@v1

@alessio-perugini
Copy link
Contributor Author

alessio-perugini commented May 30, 2023

@jbohanon Yup that's because the 28fd3e5 will be released ~tomorrow as a v2 breaking change.

Honestly, I didn't think about the users referencing the action with @master Sorry about that 🙏
Glad that you solved it by pinning at @v1 😄

EDIT: opened #81 for future users that may be facing the same issue

@jbohanon
Copy link

It's all good, I see now that your documentation has called out for quite some time that users should reference @v1. All sorted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New protobuf versionning scheme such as 21.1 is not supported
3 participants