Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates osier version #69

Merged
merged 1 commit into from
Oct 7, 2024
Merged

updates osier version #69

merged 1 commit into from
Oct 7, 2024

Conversation

samgdotson
Copy link
Collaborator

This PR closes #67 which adds a new pypi version with the pyproject.toml installation.

@samgdotson samgdotson added Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). labels Oct 4, 2024
@samgdotson samgdotson added this to the JOSS publication -- Osier milestone Oct 4, 2024
@samgdotson samgdotson self-assigned this Oct 4, 2024
@nsryan2 nsryan2 self-requested a review October 7, 2024 14:13
nsryan2
nsryan2 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@nsryan2 nsryan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would you need to change the version in the conf.py of the docs?

osier/docs/source/conf.py

Line 25 in 7e6481e

release = '0.2.1'

@nsryan2 nsryan2 merged commit a14b673 into arfc:main Oct 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsryan2 nsryan2 nsryan2 approved these changes

@yardasol yardasol Awaiting requested review from yardasol

Assignees

@samgdotson samgdotson

Labels
Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline).
Projects
None yet
Milestone
JOSS publication -- Osier
Development

Successfully merging this pull request may close these issues.

Prepare new PyPI release
2 participants
@samgdotson @nsryan2