Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v0.4.0 releasenotes + templates #122

Merged
merged 10 commits into from
Feb 15, 2022

Conversation

yardasol
Copy link
Contributor

@yardasol yardasol commented Feb 7, 2022

Summary of changes

This PR adds content from #98 and #115 to the v0.4.0 release notes.

This PR also adjusts the formatting for the release notes so they display better on GitHub, and adds a line to the template.rst file to indicate that the newest release notes on the master branch in the online docs are in production.

This PR adds a line to the next-minor-release workflow to remove the 'in-production' note when the current draft release is published.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change is a source code change
    • I have added/modified tests to cover my changes
    • I have explained why my change does not require new/modified tests
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)
  • I have recorded my changes in the changelog for the upcoming release

Associated Issues and PRs

Associated Developers

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@yardasol yardasol changed the title Fix v0.4.0 releasenotes Fix v0.4.0 releasenotes + templates Feb 8, 2022
Copy link
Contributor

@abachma2 abachma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. If no one else has comments by the end of the day I'll merge it.

@yardasol
Copy link
Contributor Author

yardasol commented Feb 13, 2022

@abachma2 the bug with miniforge that was causing our actions to fail has been fixed (see #1480 in mamba, #262 in miniforge). So the actions that will run when this is merged should all pass now

@yardasol
Copy link
Contributor Author

Scratch that. While the bug has been fixed and the mamba version updated in miniforge, I'm still running into the same bug on the workflow. My guess is that the release hasn't been fully published yet (it's just a prerelease), so the version of miniforge that has the fix isn't getting picked up by the setup-miniconda action.

@yardasol
Copy link
Contributor Author

@abachma2 actions are working again. Can you go ahead and merge?

@abachma2 abachma2 merged commit c6b3d60 into arfc:master Feb 15, 2022
github-actions bot pushed a commit that referenced this pull request Feb 15, 2022
….0-releasenotes

Fix v0.4.0 releasenotes + templates c6b3d60
github-actions bot pushed a commit to yardasol/saltproc that referenced this pull request Feb 15, 2022
…v0.4.0-releasenotes

Fix v0.4.0 releasenotes + templates c6b3d60
@yardasol yardasol deleted the fix-v0.4.0-releasenotes branch March 9, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Update 0.4.0 release notes
2 participants