-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc
additions, docstring typo fixes, cross section processing scripts
#90
Conversation
Hello @yardasol! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-12-16 20:53:40 UTC |
…or integration tests and examples
doc
additions, docstring typo fixesdoc
additions, docstring typo fixes, cross section processing scripts
Figure produced by Figure produced by Figure produced by Figure produced by I'm not seeing much of a difference between these two cross section libraries. @andrewryh do the bugs in the JEFF 3.1.2 effect nuclides not covered in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good. A few comments that I think would improve readability and use of the scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for making those changes! I'll go ahead and merge this PR.
Patch #90 (pep8 issues, docstring consistency)
Summary of changes
This PR adds the following to
doc/
:installation.rst
, a new section on cross section librariesinstallation.rst
, a new section on testingThis PR also adds a script (and an accompanying README) that users can execute to download and process the JEFF 3.1.2 library automatically for the purposes of running the examples and integration tests.
This PR also fixes typos and omissions in the docstrings from #64.
Finally, this PR updates the package version of SaltProc to 0.3.0, and designates myself as the maintainer.
This PR should be merged before #87 so we can apply the changes to the generated docs.
Types of changes
Required for Merging
Associated Issues and PRs
Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.