-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality for multiple wallets #243
Conversation
ismail9001
commented
Jun 17, 2022
- Storing by address
- Fetching list of wallets
- Deleting by address
Update README.md
…o argentlabs-master # Conflicts: # web3.swift.podspec # web3sTests/Account/EthereumAccountTests.swift
# Conflicts: # Package.resolved
Hello @ismail9001 what's the use-case for this change? Not sure if needed in the library |
Hello @DarthMike! I think these features will add popularity to your library |
@ismail9001 OK makes sense. Not sure if this exact implementation woud be the best, but need to think about it (i.e. always assuming more than one account). I'll post review comments. |
Thank you, I'll be waiting |
@ismail9001 Just reviewed the code, I think APIs would be better if we change them, see the comments in code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks now it's looking good
@ismail9001 Looks good, but we need to do PR against |
# Conflicts: # web3sTests/Account/EthereumKeyStorageTests.swift # web3sTests/Utils/KeyUtilTests.swift # web3swift/src/Account/EthereumAccount.swift # web3swift/src/Account/EthereumKeyStorage.swift
I changed destination of PR to develop |
@ismail9001 test failing when deleting keys in Linux |
I added an address output to check the reason for the test crash. Please run the test on linux |
Please run tests again |
On Linux was strange error /__w/web3.swift/web3.swift/web3sTests/ERC721/ERC721Tests.swift:150: error: ERC721MetadataTests.test_ReturnsMetatada : failed - Expected tokenMetadata but failed dataCorrupted(Swift.DecodingError.Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Foundation.JSONError.unexpectedCharacter(ascii: 60, characterIndex: 0)))). but I didnt change this functionality |
I tried to find out the cause of the problem, but only managed to find out that the test falls on the line var metadata = try JSONDecoder().decode(Token.self, from: data) in ERC721Metadata class what is the problem of the linux test, unfortunately, I cannot say |
It's passing now, so will merge |