-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention wasm-features in Readme.md
#167
Mention wasm-features in Readme.md
#167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR and apologies for the confusion this has caused!
The reason why this wasn't documented so far is that this feature isn't well tested and not part of the CI (see #89) since I don't need this feature myself and haven't had time yet to get into it in detail. I have suggested minor changes to your PR to reflect that.
If you have experience with compiling to WASM, I would be very very happy if you could add a check to the CI as well :)
Co-authored-by: Stefan Kroboth <stefan.kroboth@gmail.com>
Co-authored-by: Stefan Kroboth <stefan.kroboth@gmail.com>
Co-authored-by: Stefan Kroboth <stefan.kroboth@gmail.com>
I've implemented the requested changes! :)
I don't have much experience, unfortunately. Maybe @dariogoetz could share his sources with you though. He has set up the infrastructure of our keyboard-project. |
Thanks for making the changes! I added the same text to |
By the way, I'm just curious: When do you plan on releasing |
I plan to release it until the end of January, hopefully sooner. But unfortunately I can't guarantee it ;) |
Understood :) |
v0.5.0 is released! |
Amazing, thank you for notifying me! :) |
When important features aren't mentioned, this can lead to some confusion
Therefore, I suggest quickly mentioning them. :)
This pull-request adds a mention about WebAssembly and the required features.
Eventually, it would be handy to have every existing feature described in the
Readme.md
. Nothing extensive, just a short mention that the feature exists and an overview of what it does.