Implement KeyboardInterrupt termination #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion here, this PR implements the
KeyboardInterrupt
termination handling.I've tested that it works properly with my solver.
As a follow-up discussion, I do not need the
finalize
method as initially I introduced it as a way to have a hook just at the end of the loop to check theNotTerminated
and max iter not reached to detect keyboard interrupt like the existing check at the end of therun
function.Now that
KeyboardInterrupt
is handled I think this last check to setAborted
is useless as well, as the state is always terminated, if you're ok I remove it.