-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace assert!
macros with macros from approx crate
#327
Conversation
Thanks a lot! :) I'll provide a review soon. I will fix the clippy lints in another PR and once that is merged you can rebase this PR. New Rust version, new clippy lints ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I only have one minor request. Once this is addressed and #328 is merged you can rebase and this is good to go!
Thanks! Do you plan to make these changes also for the ndarray and nalgebra backends? You obviously don't have to, what you have done so far is already very helpful! |
Codecov ReportBase: 93.39% // Head: 93.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 119 119
Lines 18975 18975
=======================================
Hits 17721 17721
Misses 1254 1254
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Apparently everything is falling apart. I fixed the broken website build in #329. |
Good to know I'm helpful :) Not immediately at least, but maybe in the future. |
LGTM. Thanks again! :) |
Follows (278), changes every float equality check that gets run by
cargo test -p argmin-math
.