-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases for ArgminMinMax
#391
Conversation
fixed the README.md
got rid of the extra lines
removed extra lines
ArgminMinMax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Please don't open a new PR for each review, you can do all changes in one PR. There are still unnecessary changes to README.md
, probably due to a failed rebase.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
==========================================
- Coverage 90.34% 90.23% -0.11%
==========================================
Files 141 141
Lines 19869 19916 +47
==========================================
+ Hits 17950 17972 +22
- Misses 1919 1944 +25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
Please do let me know if there's anything else to be done,I'm open to all suggestions.