Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative value of computation time when stdev exists #233

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

rayandrew
Copy link
Contributor

Due to the nature of normal random equation, the value generated can be negative.

Enforcing it to be positive using abs will fix the issue.

Fix: #232

Due to the nature of normal random equation, the value generated can be
negative.

Enforcing it to be positive using `abs` will fix the issue
Copy link
Collaborator

@hariharan-devarajan hariharan-devarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zhenghh04 zhenghh04 merged commit b95fb26 into argonne-lcf:main Oct 16, 2024
6 checks passed
@rayandrew rayandrew deleted the fix/negative-computation-time branch October 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative computation time when stdev of computation time is provided
3 participants