Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix temp dir creation #24

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Conversation

zachaller
Copy link
Contributor

Signed-off-by: zachaller zachaller@users.noreply.github.com

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smallest of nitpicks

pkg/extension/context.go Outdated Show resolved Hide resolved
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@crenshaw-dev crenshaw-dev merged commit 40fcc74 into argoproj-labs:main Nov 3, 2022
crenshaw-dev pushed a commit that referenced this pull request Nov 3, 2022
* fix temp dir creation

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* wrap error instead of printing

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
rahul-mourya pushed a commit to rahul-mourya/argocd-extensions that referenced this pull request Jun 6, 2023
* fix temp dir creation

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* wrap error instead of printing

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: rahul-mourya <rahul.mourya2@ibm.com>
rahul-mourya pushed a commit to rahul-mourya/argocd-extensions that referenced this pull request Jun 6, 2023
* fix temp dir creation

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* wrap error instead of printing

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: rahul-mourya <rahul.mourya2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants