This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat: add versioning to docs #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 51.84% 51.50% -0.35%
==========================================
Files 31 31
Lines 1435 1427 -8
==========================================
- Hits 744 735 -9
Misses 556 556
- Partials 135 136 +1
Continue to review full report at Codecov.
|
alexmt
suggested changes
Feb 3, 2021
docs/assets/versions.js
Outdated
|
|
||
| // VERSION WARNINGS | ||
| window.addEventListener("DOMContentLoaded", function() { | ||
| if ((window['READTHEDOCS_DATA']).version !== "latest") { |
There was a problem hiding this comment.
Same as argoproj/argo-cd#5099 (comment) . Please change latest to default.
alexmt
pushed a commit
that referenced
this pull request
Feb 5, 2021
* feat: add versioning to docs * default versioning logic for warning banner from latest to stable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would add versioning capability through READTHEDOCS service. URLs should already be working for bringing it into https://readthedocs.org/projects/argocd-notifications/.