-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to go 1.17 and update deps #249
Conversation
sigs.k8s.io/yaml v1.3.0 | ||
) | ||
|
||
require ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the go 1.17 changes the format of this file to include 2 require()
blocks, not sure what that's about yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the number of explicit requirements may be substantially larger in an expanded Go 1.17 go.mod file, the newly-added requirements on indirect dependencies in a go 1.17 module are maintained in a separate require block from the block containing direct dependencies.
8c5c06e
to
703d203
Compare
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 75.33% 75.26% -0.07%
==========================================
Files 19 19
Lines 750 748 -2
==========================================
- Hits 565 563 -2
Misses 117 117
Partials 68 68
Continue to review full report at Codecov.
|
ffb3e4c
to
6bb45f8
Compare
da96077
to
b040016
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Updates deps and updates to using go 1.17. Some special things to call out:
IBM SM SDK removed the
CertificateSecretData
struct they were using to return cert data forpublic_cert
andimported_cert
secret types; it has been replaced with amap[string]interface{}
which simplifies our code. Code and tests updated, and confirmed to work in an e2e test.Google
gnostic
library was moved across repos which go doesn't seem to understand yet. Fixed with the suggestion given here Error parsing go.mod module declares its path as: github.com/google/gnostic but was required as: github.com/googleapis/gnostic google/gnostic#262The Vault auth libraries for
approle
anduserpass
have a weird revision that Go doesn't seem to understand. It is fixed inmain
but not any of the stable released tags. Please backport #13321 to1.9.x
branch hashicorp/vault#13528Should address
CVE-2021-43998
for Vault (though I don't think we exposed the vulnerable code here) and seems to remove theulikuntiz/xz
dep to handleCVE-2020-16845
Checklist
Please make sure that your PR fulfills the following requirements:
Type of Change
Other information