Add support for Kustomize patches to argocd_application
#360
Conversation
|
this patch feature was introduced in ArgoCD v2.9.0. However, the remaining environments are encountering failures as the system persistently attempts to add attributes to the state. Is there any example or method to limit that argument to versions above v2.9.0? (I am a complete newcomer to Terraform providers and Golang.) |
|
Hey, Thanks for this PR. #357 also attempts to upgrade the version of the ArgoCD module used here. However, there are issues with the latest version that will need to be handled. Will look at that PR first and then we can hopefully just rebase this on top of that changeset. |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Not stale |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Not stale |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Not stale |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Not stale |
There was a problem hiding this comment.
@chidambaram27 Thank you for your patience 🙏 I have now handled #357 and upgraded the underlying dependencies so we can continue with this PR now. Please see comments inline.
onematchfox
changed the title
argocd_application
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
not stale |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
not stale |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
... |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
... |
|
Hi @onematchfox , just wanna check if this PR still valid .. I totally missed it. Let me know if any changes need |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
. |
mkilchhofer
added
the
on-hold
mkilchhofer
requested review from
oboukili,
blakepettersson,
the-technat and
mkilchhofer
as code owners
|
Hi @chidambaram27 thank you for your contribution! We rebased your branch against the current codebase and reviewed the changes. One thing left is the DCO bot complaining about unsigned commits, would you mind verifying that all your commits include a |
|
@chidambaram27 please respond good sir. This feature will make my life much easier |
Signed-off-by: chidambaram27 <chidambaramk.27@gmail.com>
chidambaram27
force-pushed
the
feature/kustomize-patches
branch
from
b5f3303 to
c659b60
Compare
|
Hi team, looks like the build stage needs approval. cc: @the-technat @onematchfox |
@onematchfox looks like you need to re-review your change request. I believe @chidambaram27 did what you asked. |
|
Waiting for it too 👍 |
Signed-off-by: chidambaram27 <chidambaramk.27@gmail.com>
Closes #356