Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid label after label+annotation tracking truncation #10110

Closed
jgray1206 opened this issue Jul 27, 2022 · 1 comment · Fixed by #18256
Closed

Invalid label after label+annotation tracking truncation #10110

jgray1206 opened this issue Jul 27, 2022 · 1 comment · Fixed by #18256
Assignees
@pasha-codefresh
Labels
enhancement New feature or request

Comments

@jgray1206
Copy link

We have some apps with long names. Thankfully, in label+annotation resource tracking mode, we are able to sync most all of them! We sadly had to rename one app because it was unfortunate enough to end in a hyphen when the label was truncated to 63 chars.

Would it be possible to strip labels of ending hyphens (and other potential invalid chars) after truncating in label+annotation tracking mode? Thank you!
@pasha-codefresh pasha-codefresh self-assigned this Aug 17, 2022
@todaywasawesome todaywasawesome added the enhancement New feature or request label Aug 18, 2022
@s7an-it s7an-it mentioned this issue Oct 7, 2022
Open
3 tasks
@stormbeta
Copy link

We got bit by this recently as well, would be great if it could be fixed upstream so that we don't have to disable label tracking.

s4nji added a commit to s4nji/argo-cd that referenced this issue Mar 18, 2024
@s4nji
Fix label truncation possibly ending with invalid character argoproj#…
a507f11 
…10110
s4nji added a commit to s4nji/argo-cd that referenced this issue Mar 18, 2024
@s4nji
Fix label truncation possibly ending with invalid character argoproj#…
6a48361 
…10110

Signed-off-by: Sanjito Kurniawan <ssi@hellofresh.com>
s4nji added a commit to s4nji/argo-cd that referenced this issue Mar 18, 2024
@s4nji
fix: label truncation possibly ending with invalid character argoproj…
040e5c4 
…#10110
s4nji added a commit to s4nji/argo-cd that referenced this issue Mar 18, 2024
@s4nji
fix: label truncation possibly ending with invalid character argoproj…
f2327e9 
…#10110

Signed-off-by: Sanjito Kurniawan <ssi@hellofresh.com>
@s4nji s4nji mentioned this issue Mar 18, 2024
Closed
14 tasks
s4nji added a commit to s4nji/argo-cd that referenced this issue Mar 20, 2024
@s4nji
fix: label truncation possibly ending with invalid character argoproj…
03f154b 
…#10110

Signed-off-by: Sanjito Kurniawan <ssi@hellofresh.com>
@jannfis jannfis mentioned this issue Apr 12, 2024
Closed
3 tasks
@jannfis jannfis mentioned this issue May 16, 2024
Closed
3 tasks
@RobinsonZ RobinsonZ mentioned this issue May 16, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pasha-codefresh pasha-codefresh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@stormbeta @todaywasawesome @jgray1206 @pasha-codefresh