Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the health check for APIService a built in #1841

Closed
alexec opened this issue Jun 28, 2019 · 3 comments
Closed

Make the health check for APIService a built in #1841

alexec opened this issue Jun 28, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone
v1.2

Comments

@alexec
Copy link
Contributor

alexec commented Jun 28, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

We should make the health check for APIService a built in (native golang) one so everyone will benefit from this.

Describe the solution you'd like

See
@alexec alexec added the enhancement New feature or request label Jun 28, 2019
@alexec
Copy link
Contributor Author

alexec commented Jun 28, 2019

@ishii-masayuki/@jessesun - FYI - it'd be great to get community contributions for this one.

@alexmt
Copy link
Collaborator

alexmt commented Jul 1, 2019

There is also a failed condition (#1017 (comment)):

status:
  conditions:
  - lastTransitionTime: "2018-12-23T20:56:17Z"
    message: 'no response from https://100.68.217.200:443: Get https://100.68.217.200:443:
      dial tcp 100.68.217.200:443: getsockopt: connection refused'
    reason: FailedDiscoveryCheck
    status: "False"
    type: Available

@alexmt alexmt mentioned this issue Jul 1, 2019
Closed
@masa213f masa213f mentioned this issue Jul 11, 2019
Merged
@masa213f
Copy link
Contributor

I made a built-in health check for API Services.
Please check when you have time :-)
#1921

alexec pushed a commit that referenced this issue Jul 11, 2019
@masa213f @alexec
Issue #1841 Make the health check for APIService a built in (#1921)
641e344
@alexec alexec added this to the v1.2 milestone Jul 11, 2019
@alexec alexec added the other label Jul 11, 2019
@alexmt alexmt closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
3 participants
@alexmt @alexec @masa213f