Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error/warning condition if application destination namespace not monitored by Argo CD #4329

Closed
alexmt opened this issue Sep 14, 2020 · 3 comments · Fixed by #4434
Closed
Labels
bug Something isn't working
Milestone

Comments

@alexmt
Copy link
Collaborator

alexmt commented Sep 14, 2020

Describe the bug

No error is shown If the cluster is connected in "namespaced" mode and application is trying to a namespace that is not listed in a cluster configuration.

To Reproduce

  1. Add cluster in a namespaced mode
argocd cluster add <my-context> --namespace default
  1. Create an application that deploys resources to any different namespace.
  2. No error message is shown and all resources are shown as out-of-sync even if resources exist.

Expected behavior

Error message that explains that namespace is wrong should be shown.

Version

v1.7.4
@alexmt alexmt added the bug Something isn't working label Sep 14, 2020
@jessesuen jessesuen added this to the v1.8 milestone Sep 15, 2020
@jopit
Copy link
Contributor

jopit commented Sep 22, 2020

Hi @alexmt, based on your comment in my PR (#4352 (review)) I've been experimenting with a change to the GetManagedLiveObjs method in the gitops-engine project

https://github.com/jopit/gitops-engine/blob/af9eedc5e8485a3098405f9758ff27f69595cb65/pkg/cache/cluster.go#L679

When an application is created in a non-managed namespace (if that's the correct terminology), an error shows up on the application page

Screen Shot 2020-09-22 at 4 47 45 PM

and when you click on the error, it show this message

Screen Shot 2020-09-22 at 4 47 59 PM

Is this sort of what you had in mind for this?

The commit in my fork for this change is here: jopit/gitops-engine@af9eedc

@alexmt
Copy link
Collaborator Author

alexmt commented Sep 22, 2020

That looks correct @jopit. Can you please create PR to gitops-engine ?

@jopit
Copy link
Contributor

jopit commented Sep 23, 2020

PR is argoproj/gitops-engine#143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants