chore: don't hardcode argo-e2e* namespaces
#12871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two environment variables which are used to set namespaces other than `argo-e2e` and `argo-e2e-external`; `ARGOCD_E2E_NAMESPACE` and `ARGOCD_E2E_APP_NAMESPACE` respectively. When using these env vars, a bunch of tests fail since a lot of them hardcode `argo-e2e` or `argo-e2e-external`. This PR changes that to use either `TestNamespace()` or `AppNamespace()`, which will set the correct namespace to use if the above env vars have been set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #12871 +/- ##
=======================================
Coverage 47.77% 47.77%
=======================================
Files 246 246
Lines 42070 42070
=======================================
Hits 20101 20101
Misses 19967 19967
Partials 2002 2002 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
alexec
pushed a commit
to alexec/argo-cd
that referenced
this pull request
Mar 19, 2023
There are two environment variables which are used to set namespaces other than `argo-e2e` and `argo-e2e-external`; `ARGOCD_E2E_NAMESPACE` and `ARGOCD_E2E_APP_NAMESPACE` respectively. When using these env vars, a bunch of tests fail since a lot of them hardcode `argo-e2e` or `argo-e2e-external`. This PR changes that to use either `TestNamespace()` or `AppNamespace()`, which will set the correct namespace to use if the above env vars have been set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
There are two environment variables which are used to set namespaces other than `argo-e2e` and `argo-e2e-external`; `ARGOCD_E2E_NAMESPACE` and `ARGOCD_E2E_APP_NAMESPACE` respectively. When using these env vars, a bunch of tests fail since a lot of them hardcode `argo-e2e` or `argo-e2e-external`. This PR changes that to use either `TestNamespace()` or `AppNamespace()`, which will set the correct namespace to use if the above env vars have been set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two environment variables which are used to set namespaces other than
argo-e2eandargo-e2e-external;ARGOCD_E2E_NAMESPACEandARGOCD_E2E_APP_NAMESPACErespectively.When using these env vars, a bunch of tests fail since a lot of them hardcode
argo-e2eorargo-e2e-external. This PR changes that to use eitherTestNamespace()orAppNamespace(), which will set the correct namespace to use if the above env vars have been set.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.