-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (#13813) #14216
fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (#13813) #14216
Conversation
e146e7b
to
a08420c
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14216 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 261 261
Lines 44659 44659
=======================================
Hits 22225 22225
Misses 20249 20249
Partials 2185 2185 ☔ View full report in Codecov by Sentry. |
…ination field (fixes argoproj#13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
692ab2e
to
c2e73d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crenshaw-dev viable for merge or has to wait post 2.8 stuff? Thank you. |
I can confirm ui-test is OK! |
/cherry-pick release-2.8 |
…ination field (#13813) (#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
/cherry-pick release-2.7 |
/cherry-pick release-2.6 |
…ination field (#13813) (#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
…ination field (#13813) (#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
…ination field (argoproj#13813) (argoproj#14216) (argoproj#14627) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813) * Address linting errors --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> Co-authored-by: Kyle Purkiss <kyle.purkiss@procore.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
…ination field (argoproj#13813) (argoproj#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
…ination field (argoproj#13813) (argoproj#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
…ination field (argoproj#13813) (argoproj#14216) * fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813) Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> * Address linting errors Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com> --------- Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Fixes #13813
Currently, when users attempt to choose
NAME
in the Destination dropdown, the inner state does not change. With this PR, we move the loading of the destFormat state into a useEffect, which should address when we were reloading our state. Also addresses a React warning related to mutating our state outside of our component:Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.