Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (#13813) #14216

Conversation

Conrimaceogain
Copy link
Contributor

@Conrimaceogain Conrimaceogain commented Jun 26, 2023

Fixes #13813

Currently, when users attempt to choose NAME in the Destination dropdown, the inner state does not change. With this PR, we move the loading of the destFormat state into a useEffect, which should address when we were reloading our state. Also addresses a React warning related to mutating our state outside of our component:

Warning: Cannot update a component (`ApplicationCreatePanel`) while rendering a different component (`DataLoader`). To locate the bad setState() call inside `DataLoader`, follow the stack trace as described in https://fb.me/setstate-in-render

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@Conrimaceogain Conrimaceogain force-pushed the kbp/address-destination-dropdown-bug branch from e146e7b to a08420c Compare June 26, 2023 23:30
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1bffe34) 49.76% compared to head (c2e73d6) 49.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14216   +/-   ##
=======================================
  Coverage   49.76%   49.76%           
=======================================
  Files         261      261           
  Lines       44659    44659           
=======================================
  Hits        22225    22225           
  Misses      20249    20249           
  Partials     2185     2185           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Conrimaceogain Conrimaceogain marked this pull request as ready for review June 27, 2023 00:10
…ination field (fixes argoproj#13813)

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
@Conrimaceogain Conrimaceogain force-pushed the kbp/address-destination-dropdown-bug branch from 692ab2e to c2e73d6 Compare June 30, 2023 18:55
@crenshaw-dev crenshaw-dev requested a review from rbreeze July 7, 2023 16:41
@crenshaw-dev crenshaw-dev changed the title fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813) fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (#13813) Jul 7, 2023
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmeridth
Copy link
Member

jmeridth commented Jul 8, 2023

@crenshaw-dev viable for merge or has to wait post 2.8 stuff? Thank you.

@ebuildy
Copy link
Contributor

ebuildy commented Jul 20, 2023

I can confirm ui-test is OK!

@crenshaw-dev crenshaw-dev merged commit 278237e into argoproj:master Jul 20, 2023
6 checks passed
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.8

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 20, 2023
…ination field (#13813) (#14216)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813)

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

* Address linting errors

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
crenshaw-dev pushed a commit that referenced this pull request Jul 20, 2023
…ination field (#13813) (#14216) (#14626)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813)



* Address linting errors



---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Co-authored-by: Kyle Purkiss <kyle.purkiss@procore.com>
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.6

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 20, 2023
…ination field (#13813) (#14216)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813)

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

* Address linting errors

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 20, 2023
…ination field (#13813) (#14216)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813)

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

* Address linting errors

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
crenshaw-dev pushed a commit that referenced this pull request Jul 20, 2023
…ination field (#13813) (#14216) (#14627)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813)



* Address linting errors



---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Co-authored-by: Kyle Purkiss <kyle.purkiss@procore.com>
crenshaw-dev pushed a commit that referenced this pull request Jul 20, 2023
…ination field (#13813) (#14216) (#14628)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes #13813)



* Address linting errors



---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Co-authored-by: Kyle Purkiss <kyle.purkiss@procore.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
…ination field (argoproj#13813) (argoproj#14216) (argoproj#14627)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813)

* Address linting errors

---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Co-authored-by: Kyle Purkiss <kyle.purkiss@procore.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…ination field (argoproj#13813) (argoproj#14216)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813)

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

* Address linting errors

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
@suzaku suzaku mentioned this pull request Aug 15, 2023
Jneville0815 pushed a commit to radiusmethod/argo-cd that referenced this pull request Sep 30, 2023
…ination field (argoproj#13813) (argoproj#14216)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813)

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

* Address linting errors

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…ination field (argoproj#13813) (argoproj#14216)

* fix(ui): Fix Destination Cluster URL/Name Drop down not updating destination field (fixes argoproj#13813)

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

* Address linting errors

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>

---------

Signed-off-by: Kyle Purkiss <kyle.purkiss@procore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ArgoCD - Creating New App - Destination Cluster URL/Name Drop down not working
6 participants