-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(appset): normalize app spec before applying #14481
fix(appset): normalize app spec before applying #14481
Conversation
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14481 +/- ##
==========================================
+ Coverage 49.73% 49.76% +0.02%
==========================================
Files 261 261
Lines 44705 44758 +53
==========================================
+ Hits 22234 22272 +38
- Misses 20284 20295 +11
- Partials 2187 2191 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherry-pick release-2.8 |
/cherry-pick release-2.7 |
* fix(appset): normalize app spec before applying Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix nil ref, add test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix another test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
/cherry-pick release-2.6 |
* fix(appset): normalize app spec before applying Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix nil ref, add test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix another test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
/cherry-pick release-2.5 |
Cherry-pick failed with |
Cherry-pick failed with |
* fix(appset): normalize app spec before applying * fix nil ref, add test * fix another test --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix(appset): normalize app spec before applying * fix nil ref, add test * fix another test --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix(appset): normalize app spec before applying Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix nil ref, add test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix another test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
…oproj#14555) * fix(appset): normalize app spec before applying * fix nil ref, add test * fix another test --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
* fix(appset): normalize app spec before applying Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix nil ref, add test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix another test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix(appset): normalize app spec before applying Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix nil ref, add test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix another test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
The AppSet controller can get into a state where it fights with the application controller.
For example, try an appset like this:
Note that the application controller logs a bunch of stuff like this:
It's fighting with the appset controller.
This PR normalizes before applying so there's nothing to fight about.