Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Skip export keyword in notification docs (cherry-pick #14633) #14645

Merged
merged 1 commit into from
Jul 21, 2023
Merged

docs: Skip export keyword in notification docs (cherry-pick #14633) #14645

merged 1 commit into from
Jul 21, 2023

Commits on Jul 21, 2023

  1. docs: Skip export keyword in notification docs (#14633) 

    This change does three things:

1. It removes the `export` keyword. It's not required since the example
   executes a script where the variables are evaluated as an inline
   string. One could even argue that there is a slight security issue
   with using `export` here, since that will expose the credentials to
   all applications started in the current context.
2. It adds a space (` `) before the `PASSWORD` variable. This will keep
   it out of the user's Bash history by default. See [HISTIGNORE][bash].
3. Add a newline for clarity.

[bash]: https://www.gnu.org/software/bash/manual/bash.html#index-HISTIGNORE

Signed-off-by: Andreas Lindhé <andreas@lindhe.io>
    @lindhe
    lindhe authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    4f7a034 View commit details
    Browse the repository at this point in the history