-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add status panel extensions #15780
feat(ui): add status panel extensions #15780
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15780 +/- ##
=======================================
Coverage 49.51% 49.51%
=======================================
Files 270 270
Lines 47498 47498
=======================================
Hits 23517 23517
Misses 21669 21669
Partials 2312 2312 ☔ View full report in Codecov by Sentry. |
As a reference, I tested with this extension: https://github.com/alexymantha/argocd-progressive-sync-extension |
@alexymantha This feature looks great to me, can you present this feature in the contributor meeting and get other's opinions |
Sure @ashutosh16! I'll try to join this week's meeting if I find the time |
@alexmt What are your thoughts on this feature? Do you expect any widget to be presented differently? |
Here's my proposal for making this feature into a generic external plugin on the status panel. When a user clicks on a plugin in Argocd's status panel, a fly-out widget containing the plugin is displayed. @alexymantha Would you be interested in extending the feature to incorporate the above changes? Let me know. |
@ashutosh16 Yes I'd be happy to extend it with your suggestion! I will be working on that in the next few days |
1ab8f90
to
993e067
Compare
Signed-off-by: Alexy Mantha <alexy@mantha.dev>
Signed-off-by: Alexy Mantha <alexy@mantha.dev>
Signed-off-by: Alexy Mantha <alexy@mantha.dev>
993e067
to
662ffe0
Compare
Signed-off-by: Alexy Mantha <alexy@mantha.dev>
@alexymantha Is the PR ready for review? It would be great if we get this feature in 2.10 |
I just have a bug to iron out and it will be ready to review. I will try to get it done this week. |
@ashutosh16 Figured it out, the bug was coming from my extension, not this PR so the PR is ready to review. Here's a short video showing the flyout panel: progressive-sync.mov |
@alexymantha I pulled in the latest changes and I'm seeing few issues.
|
My bad @ashutosh16, I forgot to merge the newest changes into the extension. Can you try the latest version? Tried a similar setup as yours and it works on my side with the up to date extension |
@alexymantha Thanks for your wonderful contributions. The feature looks awesome to me and looking forward in using many ways! Screen.Recording.2023-12-15.at.2.46.17.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add extension Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename to status panel Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add docs Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add key Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix copy/paste Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * lint Signed-off-by: Alexy Mantha <alexy@mantha.dev> * document flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename Signed-off-by: Alexy Mantha <alexy@mantha.dev> * linting Signed-off-by: Alexy Mantha <alexy@mantha.dev> --------- Signed-off-by: Alexy Mantha <alexy@mantha.dev>
* add extension Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename to status panel Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add docs Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add key Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix copy/paste Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * lint Signed-off-by: Alexy Mantha <alexy@mantha.dev> * document flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename Signed-off-by: Alexy Mantha <alexy@mantha.dev> * linting Signed-off-by: Alexy Mantha <alexy@mantha.dev> --------- Signed-off-by: Alexy Mantha <alexy@mantha.dev> Signed-off-by: penglongli <pelenli@tencent.com>
* add extension Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename to status panel Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add docs Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add key Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix copy/paste Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * lint Signed-off-by: Alexy Mantha <alexy@mantha.dev> * document flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename Signed-off-by: Alexy Mantha <alexy@mantha.dev> * linting Signed-off-by: Alexy Mantha <alexy@mantha.dev> --------- Signed-off-by: Alexy Mantha <alexy@mantha.dev> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
* add extension Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename to status panel Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add docs Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add key Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix copy/paste Signed-off-by: Alexy Mantha <alexy@mantha.dev> * wip Signed-off-by: Alexy Mantha <alexy@mantha.dev> * flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * cleanup Signed-off-by: Alexy Mantha <alexy@mantha.dev> * lint Signed-off-by: Alexy Mantha <alexy@mantha.dev> * document flyout Signed-off-by: Alexy Mantha <alexy@mantha.dev> * rename Signed-off-by: Alexy Mantha <alexy@mantha.dev> * linting Signed-off-by: Alexy Mantha <alexy@mantha.dev> --------- Signed-off-by: Alexy Mantha <alexy@mantha.dev>
Adds an extension hook to the status panel. Here is an example of 2 dummy extensions using this feature:
Closes #15775
Checklist: