-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logout ability (argocd logout
)
#1582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1582 +/- ##
=========================================
+ Coverage 34.08% 34.1% +0.01%
=========================================
Files 76 77 +1
Lines 11354 11413 +59
=========================================
+ Hits 3870 3892 +22
- Misses 6951 6983 +32
- Partials 533 538 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but could this have some tests please?
@alexec Added tests! |
@alexmt or @jessesuen is this something you'd like to review? I don't know the code. |
I took a quick look. This PR is actually implementing context deletion, which is actually different (but useful) request.
Which will delete the current context. |
@jessesuen I have now included an Also, the failing E2E test seems to be a flaky test related to GitLab authentication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional approval. Please update dependencies to remove changes to openapi_generated.go
|
||
const testConfigFilePath = "./testdata/config" | ||
|
||
func TestContextDelete(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this
@@ -105,7 +105,6 @@ func schema_pkg_apis_application_v1alpha1_AWSAuthConfig(ref common.ReferenceCall | |||
}, | |||
}, | |||
}, | |||
Dependencies: []string{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These openapi changes are unexpected. Can you run:
brew upgrade protobuf
brew upgrade go-swagger
make codegen
@jessesuen Ready! |
Implements #1210. Pretty self explanatory. Current behavior if logging out from a currently selected context is to automatically select the first context that is still logged in, not sure if this is the desired behavior.