Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1701 - UI will crash when create application without destination namespace #1713

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Issue #1701 - UI will crash when create application without destination namespace #1713

merged 1 commit into from
Jun 7, 2019

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jun 7, 2019

Closes #1701

@alexmt alexmt requested review from alexec and jessesuen June 7, 2019 21:27
@alexmt alexmt mentioned this pull request Jun 7, 2019
Closed
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #1713 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
- Coverage    34.1%   34.07%   -0.04%     
==========================================
  Files          77       76       -1     
  Lines       11413    11356      -57     
==========================================
- Hits         3892     3869      -23     
+ Misses       6983     6955      -28     
+ Partials      538      532       -6
Impacted Files Coverage Δ
util/argo/argo.go 20.28% <100%> (+1.64%) ⬆️
cmd/argocd/commands/context.go 0% <0%> (-15.3%) ⬇️
cmd/argocd/commands/logout.go
cmd/argocd/commands/root.go 5.71% <0%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 893f142...ca4d7be. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 7, 2019 •
edited
Loading

Codecov Report

Merging #1713 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
- Coverage    34.1%   34.07%   -0.04%     
==========================================
  Files          77       76       -1     
  Lines       11413    11356      -57     
==========================================
- Hits         3892     3869      -23     
+ Misses       6983     6955      -28     
+ Partials      538      532       -6
Impacted Files Coverage Δ
util/argo/argo.go 20.28% <100%> (+1.64%) ⬆️
cmd/argocd/commands/context.go 0% <0%> (-15.3%) ⬇️
cmd/argocd/commands/logout.go
cmd/argocd/commands/root.go 5.71% <0%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 893f142...ca4d7be. Read the comment docs.

@alexmt alexmt merged commit 9f60933 into argoproj:master Jun 7, 2019
@alexmt alexmt deleted the 1701-empty-destination branch June 7, 2019 23:21
@alexec alexec added this to the v1.2 milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

UI will crash when create application without destination namespace
2 participants
@alexmt @alexec