Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Decoupling application sync using impersonation #17403

Merged
merged 19 commits into from
Sep 4, 2024

Made changes in the proposal to match the behaviour when no matching …

080b5ce
Select commit
Loading
Failed to load commit list.
Merged

feat: Decoupling application sync using impersonation #17403

Made changes in the proposal to match the behaviour when no matching …
080b5ce
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 4, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 15.78947% with 128 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@f071fdc). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/project.go 0.00% 96 Missing ⚠️
cmd/util/project.go 0.00% 15 Missing ⚠️
pkg/apis/application/v1alpha1/app_project_types.go 10.00% 8 Missing and 1 partial ⚠️
controller/sync.go 79.16% 2 Missing and 3 partials ⚠️
util/settings/settings.go 66.66% 1 Missing and 1 partial ⚠️
server/settings/settings.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #17403   +/-   ##
=========================================
  Coverage          ?   55.80%           
=========================================
  Files             ?      320           
  Lines             ?    44206           
  Branches          ?        0           
=========================================
  Hits              ?    24669           
  Misses            ?    16977           
  Partials          ?     2560

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov