-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement source refs for helm set-file (Beta) (#13220) #17941
Conversation
787bec9
to
a190562
Compare
This still needs testing added. The documentation pieces are in #17822, which I will rebase this PR on top once that lands. I'll readily admit I'm not a Go programmer so probably did some things wrong from an idiomatic standpoint. Hoping another contributor is willing to help me get this over the finish line. |
I've labeled this as beta since it's for multi-source applications which themselves are beta. |
Added documentation for fileParameters in a helm source Application or the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so users are aware. argoproj#17941 aims to remove this limitation so the warning will be adjusted to mention the version that lands that support. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Added documentation for fileParameters in a helm source Application or the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so users are aware. argoproj#17941 aims to remove this limitation so the warning will be adjusted to mention the version that lands that support. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Added documentation for fileParameters in a helm source Application or the --helm-set-file cli option from #2751. Added a note about #13220 so users are aware. #17941 aims to remove this limitation so the warning will be adjusted to mention the version that lands that support. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
a190562
to
ea93b75
Compare
ea93b75
to
e04ede0
Compare
87e6981
to
837f4df
Compare
I've set the documentation update to say the feature is available from ArgoCD 2.12+ because I'm assuming this won't make it into 2.11 since that's already in RC status. |
So I pushed once to confirm the test failed. And the most recent test confirms the test passes. |
@cardoe I can't open a PR against your branch, not sure why. I added one commit at morremeyer@aa090e2 that uses slices.IndexFunc to check against all manifests, not just one. Did not run the full test suite against it yet, feel free to add it to this PR. |
Thanks @morremeyer. I've squashed your change in since you prefixed it with |
I just brought this PR up in the contributor weekly since I'd love to see it merged. I'll build an image for this PR in our environment and will test it in our setup to verify it works as desired. |
I've got this patch built against 2.12.x and have been using it myself. |
Added documentation for fileParameters in a helm source Application or the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so users are aware. argoproj#17941 aims to remove this limitation so the warning will be adjusted to mention the version that lands that support. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Hello, |
13a7943
to
5a15c9d
Compare
I've rebased the branch and removed the documentation chunk that @morremeyer asked. |
5a15c9d
to
8467a13
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17941 +/- ##
==========================================
+ Coverage 50.23% 50.24% +0.01%
==========================================
Files 312 312
Lines 42969 42984 +15
==========================================
+ Hits 21584 21598 +14
Misses 18907 18907
- Partials 2478 2479 +1 ☔ View full report in Codecov by Sentry. |
8467a13
to
e845dba
Compare
In multi-source applications helm values files can come from other repos if you use the ref syntax but it is not possible for the --set-file param to take files from other repos via the ref syntax. This extends the behavior to cover set-file parameters as well as the values files. fixes argoproj#13220, refs argoproj#17822 Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
e845dba
to
ff604b3
Compare
I've rebased once again and attempted to add a test that checks for failure not just the happy path. |
Added documentation for fileParameters in a helm source Application or the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so users are aware. argoproj#17941 aims to remove this limitation so the warning will be adjusted to mention the version that lands that support. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
We have now built ArgoCD with this PR and are running it on our infrastructure for this week to validate the feature and observe performance. I'll report back about that on Friday. |
This has worked very well in our setup, from my point of view this PR is ready to be merged. Thanks @cardoe for contributing this, we'll be very happy to see it released! @crenshaw-dev Thanks for your feedback in the Contributor sync, as discussed then, we tested it in our infrastructure with success. |
Could we merge and release it? |
Like @morremeyer I'm successfully running this patch in my infra. Overall this increases test coverage. I know the codecov says there's some partials and missed tests but that's cause the calls to |
hi @morremeyer, the PR looks in a good shape 🤩, do you know if there is any news on this feature being accepted and released? |
We're also very interested for this feature, can't wait to have it released :) |
At this time we're waiting on @crenshaw-dev to review it. I've pinged him about it on Slack. |
this is a useful feature for configmap files in non-helm repos, please review it and merge so it is available to users at large. if user acceptance test is required, then i am willing to offer my services to test the feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cardoe for the PR, @agaudreault for the review, and others for the testing!
Will this be part of v2.12.0 ?? |
@spy16 No, it was merged after the first RC was made, so it will not appear in v2.12.0. We can expect it with v2.13.0 if I remember the flow correctly. |
In multi-source applications helm values files can come from other repos if you use the ref syntax but it is not possible for the --set-file param to take files from other repos via the ref syntax. This extends the behavior to cover set-file parameters as well as the values files. fixes argoproj#13220, refs argoproj#17822 Signed-off-by: Doug Goldstein <cardoe@cardoe.com> Signed-off-by: Rhys Williams <rhys.williams@electrum.co.za>
In multi-source applications helm values files can come from other repos if you use the ref syntax but it is not possible for the --set-file param to take files from other repos via the ref syntax. This extends the behavior to cover set-file parameters as well as the values files. fixes #13220, refs #17822
Checklist: