Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app names with non-alphanumeric characters in position 63 break syncs (issue #18237) (cherry-pick #18256) #18439

Merged
merged 1 commit into from
May 28, 2024

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix: app names with non-alphanumeric characters in position 63 break syncs (issue #18237) (#18256)

  • Ensure truncated app label does not end in a special character

Signed-off-by: Zack Robinson robinsoz@arcesium.com

  • Move regex to global variable and add out of bounds check

Signed-off-by: Zack Robinson robinsoz@arcesium.com

  • Add test for out-of-bounds check

Signed-off-by: Zack Robinson robinsoz@arcesium.com


Signed-off-by: Zack Robinson robinsoz@arcesium.com

…syncs (issue #18237) (#18256)

* Ensure truncated app label does not end in a special character

Signed-off-by: Zack Robinson <robinsoz@arcesium.com>

* Move regex to global variable and add out of bounds check

Signed-off-by: Zack Robinson <robinsoz@arcesium.com>

* Add test for out-of-bounds check

Signed-off-by: Zack Robinson <robinsoz@arcesium.com>

---------

Signed-off-by: Zack Robinson <robinsoz@arcesium.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner May 28, 2024 16:56
@RobinsonZ
Copy link
Contributor

The DCO check seems to be failing because the squash commit was created with my personal email while the sign-offs are from my company email. I'm not sure how this should be fixed but if possible all commits here should be using robinsoz@arcesium.com.

@pasha-codefresh pasha-codefresh merged commit 46342a9 into release-2.11 May 28, 2024
21 of 25 checks passed
@pasha-codefresh pasha-codefresh deleted the cherry-pick-6e66d7-release-2.11 branch May 28, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants