fix(health): only consider non-empty health checks (cherry-pick #20232) #20235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
* fix(health): only consider non-empty health checks For wildcard health checks, only consider wildcards with a non-empty health check. Fixes #16905 (at least partially). Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: renaming test case for clarity Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * refactor: add clarity as to what the function is supposed to do Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * Update docs/operator-manual/health.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: add test case for `*/*` override with empty healthcheck Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
approved these changes
Oct 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.13 #20235 +/- ##
================================================
+ Coverage 55.78% 55.88% +0.10%
================================================
Files 320 320
Lines 44384 44411 +27
================================================
+ Hits 24759 24821 +62
+ Misses 17060 17025 -35
Partials 2565 2565 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(health): only consider non-empty health checks (#20232)
For wildcard health checks, only consider wildcards with a non-empty
health check. Fixes #16905 (at least partially).
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
Co-authored-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
*/*override with empty healthcheckSigned-off-by: Blake Pettersson blake.pettersson@gmail.com
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
Co-authored-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com