-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support to expose ArgoCD instance URL #20327
base: master
Are you sure you want to change the base?
Conversation
…ources Signed-off-by: B Rahul <rahul20bollisetty@gmail.com>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: B Rahul <rahul20bollisetty@gmail.com>
Signed-off-by: B Rahul <rahul20bollisetty@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20327 +/- ##
=========================================
Coverage ? 56.07%
=========================================
Files ? 322
Lines ? 44826
Branches ? 0
=========================================
Hits ? 25135
Misses ? 17083
Partials ? 2608 ☔ View full report in Codecov by Sentry. |
Signed-off-by: B Rahul <rahul20bollisetty@gmail.com>
Signed-off-by: B Rahul <rahul20bollisetty@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we can make use of the AnnotationInstallationID introduced here:
#20222
It seems to tackle a slightly different but similar scenario of being able to know what instance of the multiple ArgoCDs in the cluster manages the resource.
Can this eliminate the need to specify the ArgoCD instance URL explicitly by the user?
Well that's a good addition for tracking the resources, but let's say you have multiple ArgoCD (~ 100 instance) instance, and you have access to a cluster, now you want to figure out which ArgoCD instance is managing a resource by looking at the manifest of the resource, it would be really difficult and not user-friendly to find out by just the |
Yeah, that makes sense to me, this PR is definitely a valuable addition, thank you for the implementation and for the explanation! I wonder whether there is an alternative to the user having to specify the URL explicitly? Like maybe some auto-calculation based on |
Getting the URL for an ArgoCD instance automatically is tricky because it depends on where and how it's deployed—locally or on a cloud platform like AWS EKS, GKE, or Azure AKS. For cloud deployments, you often need to manually find the LoadBalancer IP. Since there's no built-in way for ArgoCD to automatically grab the URL, you usually have to set it up manually based on your specific setup. |
FIXES #19547
This PR adds the support for exposing the info about the argocd instance in the clusters/namespaces it manages, by adding a annotation to each resource manifests when URL is configure in argocd-cm.
Checklist: