chore: simplify 'get repo' API implementation #20348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20348 +/- ##
=========================================
Coverage ? 55.99%
=========================================
Files ? 322
Lines ? 44706
Branches ? 0
=========================================
Hits ? 25031
Misses ? 17086
Partials ? 2589 ☔ View full report in Codecov by Sentry. |
austin5219
pushed a commit
to austin5219/argo-cd
that referenced
this pull request
Oct 16, 2024
* chore: simplify 'get repo' API implementation Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * import order Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository
Getendpoint currently normalizes, sanitizes, and augments the repo object with the connection status.But that work is already done by the call to
s.ListRepositories.For normalization and sanitization, the duplication is a drift risk, but isn't otherwise a problem.
The extra connection status check shouldn't be a huge problem, because it's cached. But it'll duplicate the check when anyone clicks "refresh" in the repo list UI.
I've added unit tests to confirm that
Getstill gets the normalized, sanitized, and augmented repo object. I've confirmed that, if I remove those behaviors from the ListRepositories function, the tests fail (so we would catch a regression).