Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appset): avoid panic when no steps in rollingSync #20357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CefBoud
Copy link
Contributor

@CefBoud CefBoud commented Oct 14, 2024

Closes #18817.

Description

When using Applicationset's rolling sync, having no steps in the manifest results in a panic. This PR attempts to fix that by ensuring a positive number of steps.

Additionally, applications not selected by MatchExpressions are still treated as part of Step 1 (actually Step 0 due to 1-based indexing) because the appStepMap defaults to 0 and there is no validation for the presence in the map.

These applications are not synced by the rolling sync. I suggest assigning them a value of -1 to clearly indicate that they are excluded from the sync and must be manually synced.
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@CefBoud CefBoud requested review from a team as code owners October 14, 2024 00:38
Copy link

bunnyshell bot commented Oct 14, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: cef <moncef.abboud95@gmail.com>
@CefBoud CefBoud force-pushed the fix/appset-rolling-sync-step branch from 7027c9f to e02882c Compare October 14, 2024 00:39
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (9b11b21) to head (e02882c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20357      +/-   ##
==========================================
+ Coverage   55.99%   56.01%   +0.01%     
==========================================
  Files         322      322              
  Lines       44759    44761       +2     
==========================================
+ Hits        25062    25072      +10     
+ Misses      17093    17089       -4     
+ Partials     2604     2600       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

applicationset controller crashes when rollingSync steps missing
3 participants