feat: manage clusters via proxy #20374
Merged
+844
−718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashakostohrys <pavel@codefresh.io>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
10 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20374 +/- ##
=========================================
Coverage ? 55.98%
=========================================
Files ? 322
Lines ? 44772
Branches ? 0
=========================================
Hits ? 25067
Misses ? 17105
Partials ? 2600 ☔ View full report in Codecov by Sentry. |
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
|
nice work 👍 |
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
reggie-k
reviewed
Oct 15, 2024
Signed-off-by: pashakostohrys <pavel@codefresh.io>
reggie-k
approved these changes
Oct 15, 2024
wanghong230
approved these changes
Oct 15, 2024
alexmt
approved these changes
Oct 15, 2024
|
Thanks @reggie-k for the in-depth review! |
austin5219
pushed a commit
to austin5219/argo-cd
that referenced
this pull request
Oct 16, 2024
* feat: proxy support Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: proxy support Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: proxy support Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter Signed-off-by: pashakostohrys <pavel@codefresh.io> * small improvements Signed-off-by: pashakostohrys <pavel@codefresh.io> * add cluster test Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter Signed-off-by: pashakostohrys <pavel@codefresh.io> * change error message Signed-off-by: pashakostohrys <pavel@codefresh.io> * override always will change proxy url Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix
#8314
#6043
Forked from: #9496
Huge thanks and credit to initial contributor @ls0f