Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-server): Refresh correctly server when OIDC config changes #20384

Closed
wants to merge 1 commit into from

Conversation

OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Oct 15, 2024

Fixes #18576

Very few tests in that part of the code (in fact none 😨 ) so it's hard to add one to cover this case.

I would like this to be cherry-picked as far as 2.12.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@OpenGuidou OpenGuidou requested a review from a team as a code owner October 15, 2024 15:11
Copy link

bunnyshell bot commented Oct 15, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@OpenGuidou OpenGuidou marked this pull request as draft October 15, 2024 15:11
@OpenGuidou OpenGuidou force-pushed the oidc branch 2 times, most recently from 35ac259 to 597d2c5 Compare October 15, 2024 15:16
@OpenGuidou OpenGuidou marked this pull request as ready for review October 15, 2024 16:15
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.16%. Comparing base (0f872f5) to head (ffb1af7).
Report is 84 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd-server/commands/argocd_server.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20384      +/-   ##
==========================================
- Coverage   55.17%   55.16%   -0.02%     
==========================================
  Files         324      324              
  Lines       55256    55257       +1     
==========================================
- Hits        30487    30481       -6     
- Misses      22156    22160       +4     
- Partials     2613     2616       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OpenGuidou
Copy link
Contributor Author

@argoproj/argocd-approvers any opinion about this ?

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
@OpenGuidou
Copy link
Contributor Author

Replaced by #20981

@OpenGuidou OpenGuidou closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD server doesn't pick up the new OIDC secret
2 participants