-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Helm parameters with comma #2334
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2334 +/- ##
==========================================
+ Coverage 38.76% 38.78% +0.01%
==========================================
Files 109 109
Lines 14192 14196 +4
==========================================
+ Hits 5502 5506 +4
Misses 7971 7971
Partials 719 719
Continue to review full report at Codecov.
|
8c54a9a
to
0044121
Compare
This commit fixes Helm parsing of parameters values containing a comma. The issue was first found as argoproj#1660, and fixed in argoproj#1720. However, commit 4e9772e, in argoproj#1865 removed the call to `cleanHelmParameters`, hence the regression.
0044121
to
f8b2a28
Compare
CI tests fail at step "Check nothing has changed"... I checked https://argoproj.github.io/argo-cd/developer-guide/ci/#check-nothing-has-changed-step-fails but it seems every change in the proposed patch is unrelated to changes in this PR. Is the problem on CI pipeline or in my PR ? Should I apply |
Yes please. |
@alexec Done; CI tests now succeed. |
This commit fixes Helm parsing of parameters values containing a comma.
The issue was first found as #1660, and fixed in #1720. However, commit 4e9772e, in #1865, removed the call to
cleanHelmParameters
, hence the regression.