-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Whitelisted namespace in UI #3314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3314 +/- ##
==========================================
+ Coverage 39.25% 39.28% +0.03%
==========================================
Files 175 175
Lines 19018 18956 -62
Branches 272 237 -35
==========================================
- Hits 7465 7447 -18
+ Misses 10626 10591 -35
+ Partials 927 918 -9
Continue to review full report at Codecov.
|
Seems I missed the UI part when updating the contribution guide. Fix underway @ #3315. Sorry for that, @rachelwang20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for PR @rachelwang20 . Added two minor comments. Also please resolve linter warning:
yarn run v1.19.1
$ tslint -p ./src/app
ERROR: /Users/amatyushentsev/root/go/src/github.com/argoproj/argo-cd/ui/src/app/settings/components/project-edit-panel/project-edit-panel.tsx:21:1 - Exceeds maximum line length of 180
ERROR: /Users/amatyushentsev/root/go/src/github.com/argoproj/argo-cd/ui/src/app/settings/components/project-edit-panel/project-edit-panel.tsx:21:29 - Replace `sourceRepos:·[],·destinations:·[],·roles:·[],·syncWindows:·[],·clusterResourceWhitelist:·[],·namespaceResourceBlacklist:·[],·namespaceResourceWhitelist:·[],·...props.defaultParams` with `⏎················sourceRepos:·[],⏎················destinations:·[],⏎················roles:·[],⏎················syncWindows:·[],⏎················clusterResourceWhitelist:·[],⏎················namespaceResourceBlacklist:·[],⏎················namespaceResourceWhitelist:·[],⏎················...props.defaultParams⏎············`
ui/src/app/settings/components/project-details/project-details.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/settings/components/project-edit-panel/project-edit-panel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Checklist:
Issue link: #2900