refactor: avoid loading project in frequently executed controller methods #7853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
avoid-load-project
branch
from
2963bd6
to
7494a7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #7853 +/- ##
==========================================
- Coverage 41.48% 41.48% -0.01%
==========================================
Files 169 169
Lines 22256 22254 -2
==========================================
- Hits 9234 9232 -2
Misses 11703 11703
Partials 1319 1319
Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Dec 3, 2021
…hods (#7853) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes performance degradation introduced in v2.2 changes:
handleObjectUpdatedmethod. Project is loaded to avoid reconciling app if not-permitted orphaned resource changed. It is cheaper to just reconcile app instead of loading project on every resource changeSigned-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com