Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Refactor code for rendering CLI download buttons #8587

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Feb 22, 2022

Revisiting the (slightly modified) refactoring @alexmt mentioned in #7755 (comment).

Could you help double-check on the correctness? @alexmt

image

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan requested a review from alexmt February 22, 2022 04:32
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #8587 (1453aed) into master (d738e3b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8587   +/-   ##
=======================================
  Coverage   42.43%   42.43%           
=======================================
  Files         176      176           
  Lines       22889    22891    +2     
=======================================
+ Hits         9713     9714    +1     
- Misses      11790    11791    +1     
  Partials     1386     1386           
Impacted Files Coverage Δ
util/settings/settings.go 47.91% <0.00%> (ø)
controller/cache/cache.go 12.41% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d738e3b...1453aed. Read the comment docs.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@alexmt alexmt merged commit f219888 into argoproj:master Feb 22, 2022
@terrytangyuan terrytangyuan deleted the refactor-help-download branch February 22, 2022 19:40
gdsoumya pushed a commit to gdsoumya/argo-cd that referenced this pull request Feb 23, 2022
…#8587)

* chore(ui): Refactor code for rendering CLI download buttons

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Fix spacing and add linux

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
…#8587)

* chore(ui): Refactor code for rendering CLI download buttons

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Fix spacing and add linux

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants