fix(eventbus): Bugfix for EventBus with AuthStrategyNone (#798)

argoproj · Jul 31, 2020 · 6351244 · 6351244
1 parent 099ed60
commit 6351244
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/docs/tutorials/09-service-account.md b/docs/tutorials/09-service-account.md
@@ -10,13 +10,13 @@ Based on the type of trigger, it's a good practice to create a service account w
 The sensor examples use `argo-events-sa` service account to execute all types of triggers, but it is has more permissions than needed
 ,and you may want to limit those permissions based on your use-case.
 
-### K8s Resource Trigger
+### K8s Resource and Argo Workflow Triggers
 
 * To execute Argo workflow trigger, make sure to grant `create` permission for workflows to the service account.
 
 * To trigger a any other K8s resource, make sure to grant `create` permission for that resource. 
 
-### AWS Lambda, HTTP, Slack and OpenWhisk Trigger, NATS and Kafka Triggers
+### AWS Lambda, HTTP, Slack, NATS, Kafka, and OpenWhisk Triggers
 
 For these triggers, you **don't** need any K8s role associated with the service account.
 
diff --git a/eventbus/eventbus.go b/eventbus/eventbus.go
@@ -28,7 +28,7 @@ func GetDriver(ctx context.Context, eventBusConfig eventbusv1alpha1.BusConfig, s
 	}
 	var auth *driver.Auth
 	cred := &driver.AuthCredential{}
-	if eventBusAuth == nil || eventBusAuth == &eventbusv1alpha1.AuthStrategyNone {
+	if eventBusAuth == nil || *eventBusAuth == eventbusv1alpha1.AuthStrategyNone {
 		auth = &driver.Auth{
 			Strategy: eventbusv1alpha1.AuthStrategyNone,
 		}

diff --git a/examples/eventbus/native.yaml b/examples/eventbus/native.yaml
@@ -5,7 +5,7 @@ metadata:
 spec:
   nats:
     native:
-      # Optional, defaults to 3
+      # Optional, defaults to 3. If it is < 3, set it to 3, that is the minimal requirement.
       replicas: 3
       # Optional, authen strategy, "none" or "token", defaults to "none"
       auth: token