-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new event bus breaks sensors #2278
Comments
@juliev0 - Can you take a look? |
@rwong2888 Can you provide the previous and new EventBus specs? (or otherwise, just want to make sure I understand - you went from an older Jetstream version to a newer one but otherwise nothing else changed, right?) |
We upgraded to events v1.7.3 from v1.7.2. After v1.7.3 was rolled out we upgraded the event bus from version 2.8.1 to 2.9.1. After doing so, we see sensors crash looping and we basically wipe out the entire namespace and let ArgoCD rebuild everything to settle it all down. Similar behaviour could be seen if we tried delete the ArgoCD application in v1.7.2, and we presumably can do the same on v1.7.3. We were attempting to add PruneLast annotation to the eventbus as I believe the CRD deletes before the sensors, because it's alphabetical. Perhaps, we could just rename it as z-default as a workaround.
|
got it, thanks |
@whynowy I guess we do preserve state when a Sensor is deleted and re-created, but the intention is that we do not preserve state when an EventBus is deleted and re-created, right? (basically, deleting the EventBus is the way to purge all of that state and start from scratch) |
Discussed with @whynowy. We will preserve the sensor's trigger state in this case (i.e. just use the existing key/value store). |
This issue is still happening. |
Can you please provide Sensor log, Sensor spec, and old and new EventBus specs? And which version of Argo Events are you using? |
The only solution that we found was is delete the argo-event namespace and argocd will restore it back to normal. |
Based on your Sensor log, this doesn't seem to be the same error as the one in this issue - or am I missing something? |
So this issue was first create cause I was trying to add the PruneLast option to the EventBus and when I delete the application from ArgoCD to test that, the logs that @rwong2888 provided were the ones that we got before the fix that was released. After that, we upgraded to the version that contained that fix and when I tried again these are the logs that we are seeing now. |
Okay, seems like a new issue then, right? Do you want to open up a new bug for it? |
sure thing, thanks |
When we update the jetstream eventbus version to 2.9.1, our sensors crashloop with the error below. The only way for us to recover is delete the argo-event namespace and argocd will restore it back to normal.
The text was updated successfully, but these errors were encountered: