fix: if key/value store already exists use that #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
whynowy
reviewed
Nov 8, 2022
| @@ -55,12 +55,22 @@ func (stream *SensorJetstream) Initialize() error { | |||
| } | |||
| // create Key/Value store for this Sensor (seems to be okay to call this if it already exists) | |||
| stream.keyValueStore, err = stream.MgmtConnection.JSContext.CreateKeyValue(&nats.KeyValueConfig{Bucket: stream.sensorName}) | |||
| if err != nil { | |||
| switch err { | |||
There was a problem hiding this comment.
Can we query first, if it's not existing, then create it?
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
whynowy
pushed a commit
that referenced
this pull request
Dec 12, 2022
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
bilalba
pushed a commit
to intuit-data-os/argo-events
that referenced
this pull request
Jan 9, 2023
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> Signed-off-by: Bilal Bakht Ahmad <tringingly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2278
Use the existing key/value store if it already exists.
I tested this with the following experiments involving a webhook and a sensor with a trigger that is configured as "A&&B":
kubectl applyit, send "B", verify trigger occursSigned-off-by: Julie Vogelman julie_vogelman@intuit.com