feat: AMQPEventSource extra parameters. Fixes #1007 #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Davide Berdin <davideberdin@gmail.com>
Signed-off-by: Davide Berdin <davideberdin@gmail.com>
spaghettifunk
force-pushed
the
amqp_parameters
branch
from
d9ff89a to
bb012fb
Compare
whynowy
reviewed
Jan 13, 2021
Signed-off-by: Davide Berdin <davideberdin@gmail.com>
spaghettifunk
force-pushed
the
amqp_parameters
branch
from
e1ee476 to
5dfa4f7
Compare
|
I created a |
whynowy
reviewed
Jan 13, 2021
eventsources/sources/amqp/start.go
Outdated
| @@ -155,24 +161,93 @@ func (el *EventListener) StartListening(ctx context.Context, dispatch func([]byt | |||
| } | |||
| } | |||
|
|
|||
| // setDefaults sets the default values in case the user hasn't defined them | |||
| // helps also to keep retro-compatibility with current dpeloyments | |||
| func setDefaults(eventSource *v1alpha1.AMQPEventSource) error { | |||
There was a problem hiding this comment.
It looks good to me except a minor: there's no chance/need to return error in this function. Also, please confirm it is backward compatible with real testing - I don't have an AMQP env setup, can not do a test :), thanks!
There was a problem hiding this comment.
I tested this branch using the example on the website and it works without issues. The messages below are a confirmation
{"level":"info","ts":1610568336.564611,"logger":"argo-events.eventsource","caller":"eventsources/eventing.go:350","msg":"succeeded to publish an event","eventSourceName":"amqp","eventName":"example","eventSourceType":"amqp"}
{"level":"info","ts":1610568406.6777697,"logger":"argo-events.eventsource","caller":"amqp/start.go:114","msg":"received the message","eventSourceName":"amqp","eventSourceType":"amqp","eventName":"example","message-id":""}
{"level":"info","ts":1610568406.6780057,"logger":"argo-events.eventsource","caller":"amqp/start.go:143","msg":"dispatching event ...","eventSourceName":"amqp","eventSourceType":"amqp","eventName":"example"}
{"level":"info","ts":1610568406.6828492,"logger":"argo-events.eventsource","caller":"eventsources/eventing.go:350","msg":"succeeded to publish an event","eventSourceName":"amqp","eventName":"example","eventSourceType":"amqp"}
If somebody encounters an issue, I'll be happy to fix it 😄
Signed-off-by: Davide Berdin <davideberdin@gmail.com>
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
…#1009) * add more configuration parameters to AMQPEventSource Signed-off-by: Davide Berdin <davideberdin@gmail.com> * add optional values in the amqp event source example Signed-off-by: Davide Berdin <davideberdin@gmail.com> * add nil checks and set default parameters Signed-off-by: Davide Berdin <davideberdin@gmail.com> * remove returned error from setDefaults() func) Signed-off-by: Davide Berdin <davideberdin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #1007.
The following new properties are added to the
AMQPEventSourceobject:ExchangeDeclareto set the values of the exchange in the serverQueueDeclareto hold the configuration of a queue to hold messages and deliver to consumersQueueBindto hold the configuration that binds an exchange to a queue so that publishings to the exchange will be routed to the queue when the publishing routing key matches the binding routing keyConsumeto hold the configuration to immediately starts delivering queued messagesAll these new properties are optional. The user can take a look at the
amqp.yamlexample file to see how to set them up.