feat: use status resources for controller reconciliation. Closes #1029 #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Derek Wang <whynowy@gmail.com>
|
How do we test this please? |
|
Here is the data about reconciliation times and workqueue adding times after applying an EventSource object. Before, it means it kept enqueuing and reconciling even there was only one EventSource object, which is a bug. After: |
We should get some e2e test into the project, I can work on this later. For now, I had to test manually. |
alexec
approved these changes
Jan 22, 2021
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
…proj#1029 (argoproj#1030) * feat: use status resources for controller reconciliation Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang whynowy@gmail.com
Checklist:
Closes #1029
This PR:
statussubresource for CRDs, and controllers usestatusupdate API to update object status;statuschange any more;