chore: fix e2e ci build on release branch #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <whynowy@gmail.com>
whynowy
commented
Apr 5, 2021
| @@ -14,6 +14,7 @@ GIT_TREE_STATE=$(shell if [ -z "`git status --porcelain`" ]; then echo "clean" ; | |||
| DOCKER_PUSH?=false | |||
| IMAGE_NAMESPACE?=argoproj | |||
| VERSION?=latest | |||
| BASE_VERSION:=latest | |||
There was a problem hiding this comment.
To clarify:
BASE_VERSION is the original image tag in the manifests.
VERSION is the new image tag that could be passed in during image build.
whynowy
changed the title
alexec
approved these changes
Apr 5, 2021
whynowy
added a commit
that referenced
this pull request
Apr 5, 2021
* chore: fix e2e ci build in release branch Signed-off-by: Derek Wang <whynowy@gmail.com>
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* chore: fix e2e ci build in release branch Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang whynowy@gmail.com
On release branch, the image tags in the manifests are not
latestbut the real version likev1.3.0, this makesmake startfail like https://github.com/argoproj/argo-events/runs/2272839939?check_suite_focus=true. This PR is used to fix this issue.Checklist: