fix: Ack handled messages in pulsar eventsource #1455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently consumed messages are not acknowledged by argo-events so pulsar keeps them around. This results in the whole queue flooding in when the pulsar eventsource is restarted.
Consumers should acknowledge all messages consumed. https://pulsar.apache.org/docs/en/concepts-messaging/#acknowledgement
This pull request sends acknowledgement to pulsar if the eventsource could handle the message successfully and send it to the eventbus.
Checklist: