Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ack handled messages in pulsar eventsource #1455

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

arnarg
Copy link
Contributor

@arnarg arnarg commented Dec 9, 2021

Currently consumed messages are not acknowledged by argo-events so pulsar keeps them around. This results in the whole queue flooding in when the pulsar eventsource is restarted.
Consumers should acknowledge all messages consumed. https://pulsar.apache.org/docs/en/concepts-messaging/#acknowledgement

This pull request sends acknowledgement to pulsar if the eventsource could handle the message successfully and send it to the eventbus.

Checklist:

Signed-off-by: Arnar Gauti Ingason <arnarg@fastmail.com>
@arnarg arnarg force-pushed the fix/add-pulsar-eventsource-ack branch from 8dd16b1 to 7a01d26 Compare December 9, 2021 12:29
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@whynowy whynowy merged commit cdab1e3 into argoproj:master Dec 9, 2021
@arnarg arnarg deleted the fix/add-pulsar-eventsource-ack branch December 9, 2021 19:07
whynowy pushed a commit that referenced this pull request Dec 10, 2021
Signed-off-by: Arnar Gauti Ingason <arnarg@fastmail.com>
BulkBeing pushed a commit to BulkBeing/argo-events that referenced this pull request Mar 7, 2022
Signed-off-by: Arnar Gauti Ingason <arnarg@fastmail.com>
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
Signed-off-by: Arnar Gauti Ingason <arnarg@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants