Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQS Custom endpoint support #1632

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

itamarom
Copy link
Contributor

@itamarom itamarom commented Feb 13, 2022

Checklist:

Closes #1631

Signed-off-by: itamarom <itamarnine4@gmail.com>
@itamarom itamarom force-pushed the sqs-custom-endpoint-support branch from 32b78c7 to ff57f6a Compare February 13, 2022 13:03
USERS.md Outdated
@@ -33,3 +33,4 @@ Organizations below are **officially** using Argo Events. Please send a PR with
1. [Viaduct](https://www.viaduct.ai/)
1. [WooliesX](https://wooliesx.com.au/)
1. [Woolworths Group](https://www.woolworthsgroup.com.au/)
1. [Loam](https://www.getloam.com/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical order please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed!

Signed-off-by: itamarom <itamarnine4@gmail.com>
@itamarom itamarom force-pushed the sqs-custom-endpoint-support branch from ff57f6a to c97a6f5 Compare February 15, 2022 16:33
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@whynowy whynowy merged commit 00e2ae8 into argoproj:master Feb 15, 2022
@itamarom
Copy link
Contributor Author

LGTM, thanks for the PR!

Thanks!
Do you think there's a chance for a minor version anytime soon?

@whynowy
Copy link
Member

whynowy commented Feb 15, 2022

Let's make it in v1.6.1.

aweis89 pushed a commit to aweis89/argo-events that referenced this pull request Feb 15, 2022
* feat: Add support for custom SQS endpoints

Signed-off-by: itamarom <itamarnine4@gmail.com>

Signed-off-by: Aaron Weisberg <aaronweisberg@gmail.com>
whynowy pushed a commit that referenced this pull request Feb 16, 2022
* feat: Add support for custom SQS endpoints

Signed-off-by: itamarom <itamarnine4@gmail.com>
BulkBeing pushed a commit to BulkBeing/argo-events that referenced this pull request Mar 7, 2022
* feat: Add support for custom SQS endpoints

Signed-off-by: itamarom <itamarnine4@gmail.com>
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
* feat: Add support for custom SQS endpoints

Signed-off-by: itamarom <itamarnine4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding ElasticMQ support
2 participants