feat: TLS for Jetstream #1815
Merged
feat: TLS for Jetstream #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
…Verify; also spelling fix Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
juliev0
commented
Apr 5, 2022
| cert_file: "/etc/nats-config/cluster-server-cert.pem" | ||
| key_file: "/etc/nats-config/cluster-server-key.pem" | ||
| ca_file: "/etc/nats-config/cluster-ca-cert.pem" | ||
| } |
There was a problem hiding this comment.
In some ways this belongs in server-auth.conf. I tried adding a second "cluster" section into there but I don't think NATS can handle the two sections.
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
whynowy
reviewed
Apr 6, 2022
| return fmt.Errorf("failed to delete malformed nats client auth secret, err: %w", err) | ||
| // Generate TLS self signed certificate for Jetstream cluster nodes: includes TLS private key, certificate, and CA certificate | ||
| clusterNodeHosts := []string{} | ||
| for i := 0; i < r.eventBus.Spec.JetStream.GetReplicas(); i++ { |
There was a problem hiding this comment.
Is it able to do "*.xxx"? Updating replicas will not regenerate the CERT.
There was a problem hiding this comment.
Good thinking. Let me see.
There was a problem hiding this comment.
Great, using a wildcard in the first position seems to work:
"fmt.Sprintf("*.%s.%s.svc.cluster.local", generateJetStreamServiceName(r.eventBus), r.eventBus.Namespace)"
… the DNS names passed to generate the certificate Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1797
Includes both client->server and intra-cluster
Uses self-signed certificates
Checklist: