Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trello gateway #193

Merged
merged 4 commits into from
Mar 3, 2019
Merged

Trello gateway #193

merged 4 commits into from
Mar 3, 2019

Conversation

VaibhavPage
Copy link
Contributor

No description provided.

@VaibhavPage VaibhavPage changed the title feature(): adding trello gateway Trello gateway Mar 1, 2019
magaldima
magaldima reviewed Mar 2, 2019
View reviewed changes
Copy link
Contributor

@magaldima magaldima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, left minor comment

examples/gateways/trello.yaml Outdated Show resolved Hide resolved
@VaibhavPage VaibhavPage marked this pull request as ready for review March 3, 2019 21:00
@VaibhavPage VaibhavPage requested a review from magaldima March 3, 2019 21:00
@VaibhavPage VaibhavPage added the enhancement New feature or request label Mar 3, 2019
@VaibhavPage VaibhavPage added this to the v0.8.1 milestone Mar 3, 2019
magaldima
magaldima approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@magaldima magaldima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@magaldima magaldima merged commit b3d3767 into master Mar 3, 2019
@VaibhavPage VaibhavPage deleted the trello-gateway branch March 8, 2019 01:15
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@VaibhavPage @magaldima
Trello gateway (argoproj#193)
6b95290 
* feature(): adding trello gateway

* feat(): update trello gateway

* feat(): update trello gateway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magaldima magaldima magaldima approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@VaibhavPage @magaldima