add labels to jetstream statefulset generated by eventbus controller #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2023 22:38
Signed-off-by: Sudesh Jethoe <sudesh.jethoe@fika.works>
Signed-off-by: Sudesh Jethoe <sudesh.jethoe@fika.works>
jwillker
pushed a commit
to jwillker/argo-events
that referenced
this pull request
Mar 29, 2023
…rgoproj#2510) Signed-off-by: Sudesh Jethoe <sudesh.jethoe@fika.works> Co-authored-by: Sudesh Jethoe <sudesh.jethoe@fika.works> Signed-off-by: JohnWillker <frazao.jhonn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating from the NATS EventBus to the JetStream EventBus I noticed that the deployment was blocked by our admission controller as it requires certain labels to be present on the StatefulSets and Deployments.
It seemed that the EventBus controller only appends the labels from the EventBus CRD to the EventBus StatefulSet for the NATS EventBus and not for the JetStream EventBus, this PR adds this for JetStream EventBuses as well.
Checklist: